Fix bug where COBie convert fails on empty names of related objects for assemblies

This commit is contained in:
Dion Moult
2020-07-23 13:42:41 +10:00
parent 4f1aca8ceb
commit 18a2996a93
2 changed files with 39 additions and 38 deletions
+38 -37
View File
@@ -168,41 +168,42 @@ class TestPurger:
return False
parser = argparse.ArgumentParser(
description='Runs unit tests for BIM data')
parser.add_argument(
'-p',
'--purge',
action='store_true',
help='Purge tests of deleted elements')
parser.add_argument(
'-r',
'--report',
action='store_true',
help='Generate a HTML report')
parser.add_argument(
'-c',
'--console',
action='store_true',
help='Show results in the console')
parser.add_argument(
'-f',
'--feature',
type=str,
help='Specify a feature file to test',
default='')
parser.add_argument(
'-a',
'--advanced-arguments',
type=str,
help='Specify your own arguments to Python\'s Behave',
default='')
args = vars(parser.parse_args())
if __name__ == '__main__':
parser = argparse.ArgumentParser(
description='Runs unit tests for BIM data')
parser.add_argument(
'-p',
'--purge',
action='store_true',
help='Purge tests of deleted elements')
parser.add_argument(
'-r',
'--report',
action='store_true',
help='Generate a HTML report')
parser.add_argument(
'-c',
'--console',
action='store_true',
help='Show results in the console')
parser.add_argument(
'-f',
'--feature',
type=str,
help='Specify a feature file to test',
default='')
parser.add_argument(
'-a',
'--advanced-arguments',
type=str,
help='Specify your own arguments to Python\'s Behave',
default='')
args = vars(parser.parse_args())
if args['purge']:
TestPurger().purge()
elif args['report']:
generate_report()
else:
run_tests(args)
print('# All tasks are complete :-)')
if args['purge']:
TestPurger().purge()
elif args['report']:
generate_report()
else:
run_tests(args)
print('# All tasks are complete :-)')
+1 -1
View File
@@ -357,7 +357,7 @@ class IfcCobieParser():
'CreatedOn': self.get_created_on_from_history(assembly.OwnerHistory),
'SheetName': 'Assembly',
'ParentName': self.get_object_name(assembly.RelatingObject),
'ChildNames': ','.join([o.Name for o in assembly.RelatedObjects]),
'ChildNames': ','.join([o.Name if o.Name else '' for o in assembly.RelatedObjects]),
'AssemblyType': 'n/a', # I don't understand this field
'ExtSystem': self.get_ext_system_from_history(assembly.OwnerHistory),
'ExtObject': self.get_ext_object(assembly),