Fix bug where COBie convert fails on empty names of related objects for assemblies

This commit is contained in:
Dion Moult
2020-07-23 13:42:41 +10:00
parent 4f1aca8ceb
commit 18a2996a93
2 changed files with 39 additions and 38 deletions
+38 -37
View File
@@ -168,41 +168,42 @@ class TestPurger:
return False return False
parser = argparse.ArgumentParser( if __name__ == '__main__':
description='Runs unit tests for BIM data') parser = argparse.ArgumentParser(
parser.add_argument( description='Runs unit tests for BIM data')
'-p', parser.add_argument(
'--purge', '-p',
action='store_true', '--purge',
help='Purge tests of deleted elements') action='store_true',
parser.add_argument( help='Purge tests of deleted elements')
'-r', parser.add_argument(
'--report', '-r',
action='store_true', '--report',
help='Generate a HTML report') action='store_true',
parser.add_argument( help='Generate a HTML report')
'-c', parser.add_argument(
'--console', '-c',
action='store_true', '--console',
help='Show results in the console') action='store_true',
parser.add_argument( help='Show results in the console')
'-f', parser.add_argument(
'--feature', '-f',
type=str, '--feature',
help='Specify a feature file to test', type=str,
default='') help='Specify a feature file to test',
parser.add_argument( default='')
'-a', parser.add_argument(
'--advanced-arguments', '-a',
type=str, '--advanced-arguments',
help='Specify your own arguments to Python\'s Behave', type=str,
default='') help='Specify your own arguments to Python\'s Behave',
args = vars(parser.parse_args()) default='')
args = vars(parser.parse_args())
if args['purge']: if args['purge']:
TestPurger().purge() TestPurger().purge()
elif args['report']: elif args['report']:
generate_report() generate_report()
else: else:
run_tests(args) run_tests(args)
print('# All tasks are complete :-)') print('# All tasks are complete :-)')
+1 -1
View File
@@ -357,7 +357,7 @@ class IfcCobieParser():
'CreatedOn': self.get_created_on_from_history(assembly.OwnerHistory), 'CreatedOn': self.get_created_on_from_history(assembly.OwnerHistory),
'SheetName': 'Assembly', 'SheetName': 'Assembly',
'ParentName': self.get_object_name(assembly.RelatingObject), 'ParentName': self.get_object_name(assembly.RelatingObject),
'ChildNames': ','.join([o.Name for o in assembly.RelatedObjects]), 'ChildNames': ','.join([o.Name if o.Name else '' for o in assembly.RelatedObjects]),
'AssemblyType': 'n/a', # I don't understand this field 'AssemblyType': 'n/a', # I don't understand this field
'ExtSystem': self.get_ext_system_from_history(assembly.OwnerHistory), 'ExtSystem': self.get_ext_system_from_history(assembly.OwnerHistory),
'ExtObject': self.get_ext_object(assembly), 'ExtObject': self.get_ext_object(assembly),