Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-18 19:30:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

If no plane angle unit is provided in the IFC file, create composite curves using both radians and degrees and see which 'looks best' (=successfully created and/or closed curve)

Browse Source 
Forget information about plane angle units in previously processed files
This commit is contained in:
Thomas Krijnen
2012-12-31 13:50:33 +00:00
parent b11f5929bf
commit 23450c7c39
2 changed files with 54 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/IfcGeomWires.cpp
+50 -15
View File
@@ -85,24 +85,59 @@
bool IfcGeom::convert(const Ifc2x3::IfcCompositeCurve::ptr l, TopoDS_Wire& wire) {
if ( ! Ifc::hasPlaneAngleUnit ) {
Ifc::LogMessage("Warning","Creating a composite curve without unit information:",l->entity);
Ifc::hasPlaneAngleUnit = true;
// First try radians
// Temporarily pretend we do have unit information
Ifc::hasPlaneAngleUnit = true;
bool succes_radians = false;
bool succes_degrees = false;
bool use_radians = false;
bool use_degrees = false;
// First try radians
Ifc::PlaneAngleUnit = 1.0f;
bool succes_radians = IfcGeom::convert(l,wire);
bool succes_degrees;
if ( succes_radians ) {
TopoDS_Wire wire_radians, wire_degrees;
try {
succes_radians = IfcGeom::convert(l,wire_radians);
} catch (...) {}
// Now try degrees
Ifc::PlaneAngleUnit = 0.0174532925199433f;
try {
succes_degrees = IfcGeom::convert(l,wire_degrees);
} catch (...) {}
// Restore to unknown unit state
Ifc::PlaneAngleUnit = 1.0f;
Ifc::hasPlaneAngleUnit = false;
if ( succes_degrees && ! succes_radians ) {
use_degrees = true;
} else if ( succes_radians && ! succes_degrees ) {
use_radians = true;
} else if ( succes_radians && succes_degrees ) {
if ( wire_degrees.Closed() && ! wire_radians.Closed() ) {
use_degrees = true;
} else if ( wire_radians.Closed() && ! wire_degrees.Closed() ) {
use_radians = true;
} else {
// No heuristic left to prefer the one over the other,
// apparently both variants are equally succesful.
// The curve might be composed of only straight segments.
// Let's go with the wire created using radians as that
// at least is a SI unit.
use_radians = true;
}
}
if ( use_radians ) {
Ifc::LogMessage("Notice","Used radians to create composite curve");
} else {
// Now try degrees
Ifc::PlaneAngleUnit = 0.0174532925199433f;
succes_degrees = IfcGeom::convert(l,wire);
if ( succes_degrees ) {
Ifc::LogMessage("Notice","Used degrees to create composite curve");
}
// Restore to radians
Ifc::PlaneAngleUnit = 1.0f;
wire = wire_radians;
} else if ( use_degrees ) {
Ifc::LogMessage("Notice","Used degrees to create composite curve");
wire = wire_degrees;
}
Ifc::hasPlaneAngleUnit = false;
return succes_radians || succes_degrees;
}
Ifc2x3::IfcCompositeCurveSegment::list segments = l->Segments();
src/ifcparse/IfcParse.cpp
+4 -3
View File
@@ -638,7 +638,7 @@ bool Ifc::Init(IfcParse::File* f) {
int x = 0;
EntityPtr e;
IfcUtil::IfcSchemaEntity entity = 0;
if ( log1 ) std::cout << "Scanning file..." << std::endl;
if ( log1 ) (*log1) << "Scanning file..." << std::endl;
while ( ! file->eof ) {
if ( currentId ) {
try {
@@ -649,7 +649,7 @@ bool Ifc::Init(IfcParse::File* f) {
Ifc::LogMessage("Error",ex.what());
continue;
}
if ( log1 && !((++x)%1000) ) std::cout << "\r#" << currentId << " " << std::flush;
if ( log1 && !((++x)%1000) ) (*log1) << "\r#" << currentId << " " << std::flush;
if ( entity->is(Ifc2x3::Type::IfcRoot) ) {
Ifc2x3::IfcRoot::ptr ifc_root = (Ifc2x3::IfcRoot::ptr) entity;
try {
@@ -702,8 +702,9 @@ bool Ifc::Init(IfcParse::File* f) {
previous = token;
}
if ( log1 ) std::cout << "\rDone scanning file " << std::endl;
if ( log1 ) (*log1) << "\rDone scanning file " << std::endl;
hasPlaneAngleUnit = false;
Ifc2x3::IfcUnitAssignment::list unit_assignments = EntitiesByType<Ifc2x3::IfcUnitAssignment>();
IfcUtil::IfcAbstractSelect::list units = IfcUtil::IfcAbstractSelect::list();
if ( unit_assignments->Size() ) {