wgpu tests: port selection + visibility state coverage

Two Tier-1 unit binaries under src/ifcviewer-wgpu/tests/ — same Catch2 + CTest harness as the surviving GL-side tests, gated by BUILD_BONSAIVIEWER_TESTS. - test_wgpu_selection: 17 cases / 71 assertions covering replace, add, remove, toggle, clear, contains, count, selectionIds, fillFlagsArray, active-id semantics, dirty-bit, and id == 0 sentinel handling. - test_wgpu_visibility: 8 cases / 27 assertions covering hide, show, clear, isHidden, hiddenIds, idempotence, and the 0 sentinel. The wgpu state classes have a deliberately simpler shape than the GL ones (no Q_OBJECT, no signals — replaced by a dirty bit; no bulk set/add/remove methods — bulk behaviour lives in the viewport verbs). One *intentional* behavioural difference is documented in the test: add(id) steals active in the wgpu API, where GL's addToSelection kept the prior active. Each pick should drive the properties panel to the most recently touched object. Bulk hide/isolate/show-all semantics live in WgpuViewportWindow, which composes WgpuVisibilityState + the model instance lists; those are integration-level, not Tier-1, so they're not covered here. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-08-29 00:03:17 +00:00 · 2026-06-01 17:39:34 +10:00
parent 2981500b3b
commit 379f913f65
4 changed files with 413 additions and 0 deletions
@@ -0,0 +1,118 @@
+/********************************************************************************
+ *                                                                              *
+ * This file is part of IfcOpenShell.                                           *
+ *                                                                              *
+ * IfcOpenShell is free software: you can redistribute it and/or modify         *
+ * it under the terms of the Lesser GNU General Public License as published by  *
+ * the Free Software Foundation, either version 3.0 of the License, or          *
+ * (at your option) any later version.                                          *
+ *                                                                              *
+ * IfcOpenShell is distributed in the hope that it will be useful,              *
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of               *
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the                 *
+ * Lesser GNU General Public License for more details.                          *
+ *                                                                              *
+ * You should have received a copy of the Lesser GNU General Public License     *
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.         *
+ *                                                                              *
+ ********************************************************************************/
+
+// Tier-1 coverage of WgpuVisibilityState — the per-element hidden-id set
+// consulted in cull. The class is pure stdlib; this test exercises its
+// primitives directly. Bulk hide/isolate/show-all semantics live in
+// WgpuViewportWindow (which composes WgpuVisibilityState + the model
+// instance lists) and would need an integration test, not a Tier-1 unit.
+
+#include "WgpuVisibilityState.h"
+
+#include <catch2/catch_test_macros.hpp>
+
+TEST_CASE("WgpuVisibilityState starts empty", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+    REQUIRE(vis.hiddenCount() == 0);
+    REQUIRE_FALSE(vis.isHidden(0));        // 0 is the "no object" sentinel
+    REQUIRE_FALSE(vis.isHidden(1));
+    REQUIRE_FALSE(vis.isHidden(1u << 20));
+}
+
+TEST_CASE("hide(id) records the id; isHidden reflects it",
+          "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+
+    vis.hide(1);
+    vis.hide(2);
+    vis.hide(3);
+
+    REQUIRE(vis.hiddenCount() == 3);
+    REQUIRE(vis.isHidden(1));
+    REQUIRE(vis.isHidden(2));
+    REQUIRE(vis.isHidden(3));
+    REQUIRE_FALSE(vis.isHidden(4));
+}
+
+TEST_CASE("hide is idempotent", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+
+    vis.hide(5);
+    vis.hide(5);
+    vis.hide(5);
+
+    REQUIRE(vis.hiddenCount() == 1);
+    REQUIRE(vis.isHidden(5));
+}
+
+TEST_CASE("hide(0) is ignored", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+
+    vis.hide(0);
+    REQUIRE(vis.hiddenCount() == 0);
+    REQUIRE_FALSE(vis.isHidden(0));
+}
+
+TEST_CASE("show(id) removes a previously hidden id",
+          "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+    vis.hide(1);
+    vis.hide(2);
+
+    vis.show(1);
+    REQUIRE(vis.hiddenCount() == 1);
+    REQUIRE_FALSE(vis.isHidden(1));
+    REQUIRE(vis.isHidden(2));
+}
+
+TEST_CASE("show(non-hidden) is a no-op", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+    vis.hide(1);
+
+    vis.show(99);                 // never hidden
+    REQUIRE(vis.hiddenCount() == 1);
+    REQUIRE(vis.isHidden(1));
+}
+
+TEST_CASE("clear() drops every hidden id", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+    vis.hide(1);
+    vis.hide(2);
+    vis.hide(3);
+
+    vis.clear();
+    REQUIRE(vis.hiddenCount() == 0);
+    REQUIRE_FALSE(vis.isHidden(1));
+    REQUIRE_FALSE(vis.isHidden(2));
+    REQUIRE_FALSE(vis.isHidden(3));
+}
+
+TEST_CASE("hiddenIds returns the live set", "[wgpu-visibility]") {
+    WgpuVisibilityState vis;
+    vis.hide(10);
+    vis.hide(20);
+    vis.hide(30);
+
+    const auto& ids = vis.hiddenIds();
+    REQUIRE(ids.size() == 3);
+    REQUIRE(ids.count(10) == 1);
+    REQUIRE(ids.count(20) == 1);
+    REQUIRE(ids.count(30) == 1);
+    REQUIRE(ids.count(40) == 0);
+}