Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 09:21:46 +00:00
Code Issues Packages Projects Releases Wiki Activity

Update unit.py - convert function, case issue

Browse Source 
Hi,
I noticed an issue and suggest a fix:
Unit names from <si_conversions> are all lowercase, whereas project units extracted from the IFC files with <get_project_unit(...).Name> are uppercase. So the convert function didn't seem to work properly.
Hope this helps!
This commit is contained in:
ceegartner
2023-10-26 16:50:53 +02:00
parent cc338d8acc
commit 4336b9c1ae
1 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/util/unit.py
+4 -4
View File
@@ -506,8 +506,8 @@ def convert(value, from_prefix, from_unit, to_prefix, to_unit):
:return: The converted value.
:rtype: float
"""
if from_unit in si_conversions:
value *= si_conversions[from_unit]
if from_unit.lower() in si_conversions:
value *= si_conversions[from_unit.lower()]
elif from_prefix:
value *= get_prefix_multiplier(from_prefix)
if "SQUARE" in from_unit:
@@ -515,8 +515,8 @@ def convert(value, from_prefix, from_unit, to_prefix, to_unit):
elif "CUBIC" in from_unit:
value *= get_prefix_multiplier(from_prefix)
value *= get_prefix_multiplier(from_prefix)
if to_unit in si_conversions:
return value * (1 / si_conversions[to_unit])
if to_unit.lower() in si_conversions:
return value * (1 / si_conversions[to_unit.lower()])
elif to_prefix:
value *= 1 / get_prefix_multiplier(to_prefix)
if "SQUARE" in from_unit: