Fix #1557. Surface style attributes can now be explicitly edited.

src/ifcopenshell-python/ifcopenshell/api/style/data.py

@@ -0,0 +1,14 @@
+class Data:
+    styles = {}
+
+    @classmethod
+    def purge(cls):
+        cls.styles = {}
+
+    @classmethod
+    def load(cls, file, style_id):
+        if not file:
+            return
+        data = file.by_id(style_id).get_info()
+        data["Styles"] = [s.id() for s in data["Styles"]]
+        cls.styles[style_id] = data

src/ifcopenshell-python/ifcopenshell/api/style/edit_style.py

@@ -1,67 +1,10 @@
 class Usecase:
     def __init__(self, file, **settings):
         self.file = file
-        self.settings = {
-            "style": None,
-            "surface_colour": [], # RGB
-            "diffuse_colour": [], # RGB
-            "transparency": 0,
-            "external_definition": {
-                "location": None,
-                "identification": None,
-                "name": "Name"
-            },
-        }
+        self.settings = {"style": None, "attributes": {}}
         for key, value in settings.items():
             self.settings[key] = value
 
     def execute(self):
-        #has_external_definition = None
-        for element in self.file.traverse(self.settings["style"]):
-            if element.is_a("IfcSurfaceStyleShading"):
-                if element.SurfaceColour:
-                    self.update_colour_rgb(element.SurfaceColour, self.settings["surface_colour"])
-                else:
-                    element.SurfaceColour = self.create_colour_rgb(self.settings["surface_colour"])
-                element.Transparency = (self.settings["transparency"] - 1) * -1
-            if element.is_a("IfcSurfaceStyleRendering"):
-                if element.DiffuseColour:
-                    self.update_colour_rgb(element.DiffuseColour, self.settings["diffuse_colour"])
-                else:
-                    element.DiffuseColour = self.create_colour_rgb(self.settings["diffuse_colour"])
-            # TODO: Move to separate usecase
-            #if element.is_a("IfcExternallyDefinedSurfaceStyle"):
-            #    element.Location = self.settings["location"]
-            #    element.Identification = self.settings["identification"]
-            #    element.Name = self.settings["name"]
-            #    has_external_definition = True
-        #if not has_external_definition:
-        #    styles = list(self.settings["style"].Styles)
-        #    styles.append(self.create_externally_defined_surface_style())
-        #    self.settings["style"].Styles = styles
-        return self.settings["style"]
-
-    def create_surface_style_rendering(self):
-        return self.file.create_entity("IfcSurfaceStyleRendering", **{
-            "SurfaceColour": self.create_colour_rgb(self.settings["surface_colour"]),
-            "Transparency": (self.settings["transparency"] - 1) * -1,
-            "ReflectanceMethod": "NOTDEFINED",
-            "DiffuseColour": self.create_colour_rgb(self.settings["diffuse_colour"])
-        })
-
-    def create_externally_defined_surface_style(self):
-        self.file.create_entity(
-            "IfcExternallyDefinedSurfaceStyle", **{
-                "Location": self.settings["location"],
-                "Identification": self.settings["identification"],
-                "Name": self.settings["name"],
-            }
-        )
-
-    def create_colour_rgb(self, colour):
-        return self.file.createIfcColourRgb(None, colour[0], colour[1], colour[2])
-
-    def update_colour_rgb(self, element, colour):
-        element[1] = colour[0]
-        element[2] = colour[1]
-        element[3] = colour[2]
+        for name, value in self.settings["attributes"].items():
+            setattr(self.settings["style"], name, value)

src/ifcopenshell-python/ifcopenshell/api/style/edit_style_colours.py

@@ -0,0 +1,67 @@
+class Usecase:
+    def __init__(self, file, **settings):
+        self.file = file
+        self.settings = {
+            "style": None,
+            "surface_colour": [], # RGB
+            "diffuse_colour": [], # RGB
+            "transparency": 0,
+            "external_definition": {
+                "location": None,
+                "identification": None,
+                "name": "Name"
+            },
+        }
+        for key, value in settings.items():
+            self.settings[key] = value
+
+    def execute(self):
+        #has_external_definition = None
+        for element in self.file.traverse(self.settings["style"]):
+            if element.is_a("IfcSurfaceStyleShading"):
+                if element.SurfaceColour:
+                    self.update_colour_rgb(element.SurfaceColour, self.settings["surface_colour"])
+                else:
+                    element.SurfaceColour = self.create_colour_rgb(self.settings["surface_colour"])
+                element.Transparency = (self.settings["transparency"] - 1) * -1
+            if element.is_a("IfcSurfaceStyleRendering"):
+                if element.DiffuseColour:
+                    self.update_colour_rgb(element.DiffuseColour, self.settings["diffuse_colour"])
+                else:
+                    element.DiffuseColour = self.create_colour_rgb(self.settings["diffuse_colour"])
+            # TODO: Move to separate usecase
+            #if element.is_a("IfcExternallyDefinedSurfaceStyle"):
+            #    element.Location = self.settings["location"]
+            #    element.Identification = self.settings["identification"]
+            #    element.Name = self.settings["name"]
+            #    has_external_definition = True
+        #if not has_external_definition:
+        #    styles = list(self.settings["style"].Styles)
+        #    styles.append(self.create_externally_defined_surface_style())
+        #    self.settings["style"].Styles = styles
+        return self.settings["style"]
+
+    def create_surface_style_rendering(self):
+        return self.file.create_entity("IfcSurfaceStyleRendering", **{
+            "SurfaceColour": self.create_colour_rgb(self.settings["surface_colour"]),
+            "Transparency": (self.settings["transparency"] - 1) * -1,
+            "ReflectanceMethod": "NOTDEFINED",
+            "DiffuseColour": self.create_colour_rgb(self.settings["diffuse_colour"])
+        })
+
+    def create_externally_defined_surface_style(self):
+        self.file.create_entity(
+            "IfcExternallyDefinedSurfaceStyle", **{
+                "Location": self.settings["location"],
+                "Identification": self.settings["identification"],
+                "Name": self.settings["name"],
+            }
+        )
+
+    def create_colour_rgb(self, colour):
+        return self.file.createIfcColourRgb(None, colour[0], colour[1], colour[2])
+
+    def update_colour_rgb(self, element, colour):
+        element[1] = colour[0]
+        element[2] = colour[1]
+        element[3] = colour[2]