Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-10 09:48:32 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3974. Bug where orphaned histories would be left in API remove operations.

Browse Source
This commit is contained in:
Dion Moult
2023-11-28 10:45:49 +11:00
parent 58414777be
commit 6e932ec2fb
50 changed files with 314 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/geometry/connect_element.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -44,7 +45,10 @@ class Usecase:
if incompatible_connections:
for connection in set(incompatible_connections):
history = connection.OwnerHistory
self.file.remove(connection)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
for rel in self.settings["relating_element"].ConnectedTo:
if rel.is_a() == "IfcRelConnectsElements" and rel.RelatedElement == self.settings["related_element"]:
src/ifcopenshell-python/ifcopenshell/api/geometry/connect_path.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -77,7 +78,10 @@ class Usecase:
if incompatible_connections:
for connection in set(incompatible_connections):
history = connection.OwnerHistory
self.file.remove(connection)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
return self.file.createIfcRelConnectsPathElements(
ifcopenshell.guid.new(),
src/ifcopenshell-python/ifcopenshell/api/geometry/disconnect_element.py
+6
View File
@@ -16,6 +16,9 @@
# You should have received a copy of the GNU Lesser General Public License
# along with IfcOpenShell. If not, see <http://www.gnu.org/licenses/>.
import ifcopenshell
import ifcopenshell.util.element
class Usecase:
def __init__(self, file, **settings):
@@ -48,4 +51,7 @@ class Usecase:
if incompatible_connections:
for connection in set(incompatible_connections):
history = connection.OwnerHistory
self.file.remove(connection)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
src/ifcopenshell-python/ifcopenshell/api/geometry/disconnect_path.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -51,4 +52,7 @@ class Usecase:
]
for connection in set(connections):
history = connection.OwnerHistory
self.file.remove(connection)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)