Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-09 17:31:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix #3974. Bug where orphaned histories would be left in API remove operations.

Browse Source
This commit is contained in:
Dion Moult
2023-11-28 10:45:49 +11:00
parent 58414777be
commit 6e932ec2fb
50 changed files with 314 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/spatial/assign_container.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
import ifcopenshell.util.placement
@@ -120,7 +121,10 @@ class Usecase:
contained_in_structure[0].RelatedElements = related_elements
ifcopenshell.api.run("owner.update_owner_history", self.file, **{"element": contained_in_structure[0]})
else:
history = contained_in_structure[0].OwnerHistory
self.file.remove(contained_in_structure[0])
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
if contains_elements:
related_elements = list(contains_elements[0].RelatedElements)
src/ifcopenshell-python/ifcopenshell/api/spatial/dereference_structure.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -77,4 +78,7 @@ class Usecase:
rel.RelatedElements = related_elements
ifcopenshell.api.run("owner.update_owner_history", self.file, **{"element": rel})
else:
history = rel.OwnerHistory
self.file.remove(rel)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
src/ifcopenshell-python/ifcopenshell/api/spatial/remove_container.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -70,4 +71,7 @@ class Usecase:
contained_in_structure[0].RelatedElements = related_elements
ifcopenshell.api.run("owner.update_owner_history", self.file, **{"element": contained_in_structure[0]})
else:
history = contained_in_structure[0].OwnerHistory
self.file.remove(contained_in_structure[0])
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)
src/ifcopenshell-python/ifcopenshell/api/spatial/unassign_container.py
+4
View File
@@ -18,6 +18,7 @@
import ifcopenshell
import ifcopenshell.api
import ifcopenshell.util.element
class Usecase:
@@ -67,4 +68,7 @@ class Usecase:
rel.RelatedElements = related_elements
ifcopenshell.api.run("owner.update_owner_history", self.file, element=rel)
else:
history = rel.OwnerHistory
self.file.remove(rel)
if history:
ifcopenshell.util.element.remove_deep2(self.file, history)