Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-10-03 13:28:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove outdated todo note

Browse Source
This commit is contained in:
Thomas Krijnen
2024-04-29 21:03:09 +02:00
parent 710f19af08
commit 6f540e61ac
2 changed files with 0 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/serializers/ColladaSerializer.cpp
-3
View File
@@ -336,9 +336,6 @@ void ColladaSerializer::ColladaExporter::ColladaMaterials::ColladaEffects::close
void ColladaSerializer::ColladaExporter::ColladaMaterials::add(const ifcopenshell::geometry::taxonomy::style& material) { void ColladaSerializer::ColladaExporter::ColladaMaterials::add(const ifcopenshell::geometry::taxonomy::style& material) {
if (!contains(material)) { if (!contains(material)) {
// std::string material_name = (serializer->settings().get(SerializerSettings::USE_MATERIAL_NAMES)
// ? material.original_name() : material.name());
// @todo
std::string material_name = material.name; std::string material_name = material.name;
if (material_name.empty()) { if (material_name.empty()) {
src/serializers/WavefrontObjSerializer.cpp
-9
View File
@@ -61,9 +61,6 @@ void WaveFrontOBJSerializer::writeHeader() {
void WaveFrontOBJSerializer::writeMaterial(const ifcopenshell::geometry::taxonomy::style& style) void WaveFrontOBJSerializer::writeMaterial(const ifcopenshell::geometry::taxonomy::style& style)
{ {
// std::string material_name = (settings().get(SerializerSettings::USE_MATERIAL_NAMES)
// ? style.original_name() : style.name());
// @todo original_name
std::string material_name = style.name; std::string material_name = style.name;
IfcUtil::sanitate_material_name(material_name); IfcUtil::sanitate_material_name(material_name);
mtl_stream.stream << "newmtl " << material_name << "\n"; mtl_stream.stream << "newmtl " << material_name << "\n";
@@ -131,9 +128,6 @@ void WaveFrontOBJSerializer::write(const IfcGeom::TriangulationElement* o)
const int material_id = *(material_it++); const int material_id = *(material_it++);
if (material_id != previous_material_id) { if (material_id != previous_material_id) {
const ifcopenshell::geometry::taxonomy::style& material = mesh.materials()[material_id]; const ifcopenshell::geometry::taxonomy::style& material = mesh.materials()[material_id];
// std::string material_name = (settings().get(SerializerSettings::USE_MATERIAL_NAMES)
// ? material.original_name() : material.name());
// @todo original_name
std::string material_name = material.name; std::string material_name = material.name;
IfcUtil::sanitate_material_name(material_name); IfcUtil::sanitate_material_name(material_name);
obj_stream.stream << "usemtl " << material_name << "\n"; obj_stream.stream << "usemtl " << material_name << "\n";
@@ -177,9 +171,6 @@ void WaveFrontOBJSerializer::write(const IfcGeom::TriangulationElement* o)
if (material_id != previous_material_id) { if (material_id != previous_material_id) {
const ifcopenshell::geometry::taxonomy::style& material = mesh.materials()[material_id]; const ifcopenshell::geometry::taxonomy::style& material = mesh.materials()[material_id];
// std::string material_name = (settings().get(SerializerSettings::USE_MATERIAL_NAMES)
// ? material.original_name() : material.name());
// @todo original_name
std::string material_name = material.name; std::string material_name = material.name;
IfcUtil::sanitate_material_name(material_name); IfcUtil::sanitate_material_name(material_name);
obj_stream.stream << "usemtl " << material_name << "\n"; obj_stream.stream << "usemtl " << material_name << "\n";