Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-18 06:21:40 +00:00
Code Issues Packages Projects Releases Wiki Activity

Improve geometry guessing to also check placements of random sample of elements (not just site and building), not just geometry

Browse Source
This commit is contained in:
Dion Moult
2023-11-21 14:20:57 +11:00
parent 37a9a1b5d9
commit 9ffe56e64d
1 changed files with 9 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/blenderbim/blenderbim/bim/import_ifc.py
+9 -5
View File
@@ -616,11 +616,11 @@ class IfcImporter:
project = self.file.by_type("IfcContext")[0] project = self.file.by_type("IfcContext")[0]
site = self.find_decomposed_ifc_class(project, "IfcSite") site = self.find_decomposed_ifc_class(project, "IfcSite")
if site and self.is_element_far_away(site): if site and self.is_element_far_away(site):
return self.guess_georeferencing(site) return self.guess_false_origin_and_project_north(site)
building = self.find_decomposed_ifc_class(project, "IfcBuilding") building = self.find_decomposed_ifc_class(project, "IfcBuilding")
if building and self.is_element_far_away(building): if building and self.is_element_far_away(building):
return self.guess_georeferencing(building) return self.guess_false_origin_and_project_north(building)
return self.guess_absolute_coordinate() return self.guess_false_origin()
def set_manual_blender_offset(self): def set_manual_blender_offset(self):
props = bpy.context.scene.BIMGeoreferenceProperties props = bpy.context.scene.BIMGeoreferenceProperties
@@ -629,7 +629,7 @@ class IfcImporter:
props.blender_orthogonal_height = str(self.ifc_import_settings.false_origin[2]) props.blender_orthogonal_height = str(self.ifc_import_settings.false_origin[2])
props.has_blender_offset = True props.has_blender_offset = True
def guess_georeferencing(self, element): def guess_false_origin_and_project_north(self, element):
if not element.ObjectPlacement or not element.ObjectPlacement.is_a("IfcLocalPlacement"): if not element.ObjectPlacement or not element.ObjectPlacement.is_a("IfcLocalPlacement"):
return return
placement = ifcopenshell.util.placement.get_local_placement(element.ObjectPlacement) placement = ifcopenshell.util.placement.get_local_placement(element.ObjectPlacement)
@@ -644,7 +644,7 @@ class IfcImporter:
props.blender_x_axis_ordinate = str(placement[1][0]) props.blender_x_axis_ordinate = str(placement[1][0])
props.has_blender_offset = True props.has_blender_offset = True
def guess_absolute_coordinate(self): def guess_false_origin(self):
# Civil BIM applications like to work in absolute coordinates, where the # Civil BIM applications like to work in absolute coordinates, where the
# ObjectPlacement is usually 0,0,0 (but not always, so we'll need to # ObjectPlacement is usually 0,0,0 (but not always, so we'll need to
# check for the actual transformation) but each individual coordinate of # check for the actual transformation) but each individual coordinate of
@@ -668,6 +668,10 @@ class IfcImporter:
elements_checked += 1 elements_checked += 1
if elements_checked > element_checking_threshold: if elements_checked > element_checking_threshold:
return return
if element.ObjectPlacement and element.ObjectPlacement.is_a("IfcLocalPlacement"):
placement = ifcopenshell.util.placement.get_local_placement(element.ObjectPlacement)[:,3][0:3]
if self.is_point_far_away(placement, is_meters=False):
return placement
if not self.does_element_likely_have_geometry_far_away(element): if not self.does_element_likely_have_geometry_far_away(element):
continue continue
shape = self.create_generic_shape(element) shape = self.create_generic_shape(element)