Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-12 10:33:20 +00:00
Code Issues Packages Projects Releases Wiki Activity

Don't blindly assumes openings have representations for the selected contexts. #4832

Browse Source
This commit is contained in:
Thomas Krijnen
2024-06-11 15:25:03 +02:00
parent d400a48a9d
commit acd4274136
1 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/Converter.cpp
+18 -2
View File
@@ -174,10 +174,26 @@ IfcGeom::BRepElement* ifcopenshell::geometry::Converter::create_brep_for_represe
std::transform(openings->begin(), openings->end(), std::back_inserter(opening_items), [this](IfcUtil::IfcBaseClass* opening) {
auto prod_item = mapping()->map(opening);
return std::make_pair(mapping()->map(mapping()->representation_of(opening->as<IfcUtil::IfcBaseEntity>())), *taxonomy::cast<taxonomy::geom_item>(prod_item)->matrix);
auto repr = mapping()->representation_of(opening->as<IfcUtil::IfcBaseEntity>());
if (repr) {
return std::make_pair(mapping()->map(repr), *taxonomy::cast<taxonomy::geom_item>(prod_item)->matrix);
} else {
return std::make_pair(taxonomy::ptr{}, taxonomy::matrix4{});
}
});
kernel_->convert_openings(product, opening_items, shapes, *place, opened_shapes);
opening_items.erase(
std::remove_if(
opening_items.begin(),
opening_items.end(),
[](const std::pair<taxonomy::ptr, taxonomy::matrix4>& p) { return !p.first; }
), opening_items.end());
if (opening_items.empty()) {
opened_shapes = shapes;
} else {
kernel_->convert_openings(product, opening_items, shapes, *place, opened_shapes);
}
} catch (const std::exception& e) {
Logger::Message(Logger::LOG_ERROR, std::string("Error processing openings for: ") + e.what() + ":", product);
caught_error = true;