Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-09 13:52:23 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix error that stopped user from adding properties

Browse Source
This commit is contained in:
Vukas Pajic
2022-07-01 13:41:20 +02:00
committed by GitHub
parent 4ad4bdef3b
commit c73fedaaaf
1 changed files with 9 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcopenshell-python/ifcopenshell/api/pset/edit_pset.py
+9 -6
View File
@@ -102,9 +102,11 @@ class Usecase:
if value is None: if value is None:
continue continue
if isinstance(value, ifcopenshell.entity_instance): if isinstance(value, ifcopenshell.entity_instance):
nominal_value = value
if value.is_a(True) == "IFC4.IfcPropertyEnumeratedValue": if value.is_a(True) == "IFC4.IfcPropertyEnumeratedValue":
properties.append(value) properties.append(value)
continue
else:
nominal_value = value
#TODO-The following "elif" is temporary code, will need to refactor at some point - vulevukusej #TODO-The following "elif" is temporary code, will need to refactor at some point - vulevukusej
elif isinstance(value, list): elif isinstance(value, list):
for pset_template in self.settings["pset_template"].HasPropertyTemplates: for pset_template in self.settings["pset_template"].HasPropertyTemplates:
@@ -122,17 +124,18 @@ class Usecase:
EnumerationReference=prop_enum EnumerationReference=prop_enum
) )
properties.append(prop_enum_value) properties.append(prop_enum_value)
continue
else: else:
primary_measure_type = self.get_primary_measure_type(name, new_value=value) primary_measure_type = self.get_primary_measure_type(name, new_value=value)
value = self.cast_value_to_primary_measure_type(value, primary_measure_type) value = self.cast_value_to_primary_measure_type(value, primary_measure_type)
nominal_value = self.file.create_entity(primary_measure_type, value) nominal_value = self.file.create_entity(primary_measure_type, value)
properties.append( properties.append(
self.file.create_entity( self.file.create_entity(
"IfcPropertySingleValue", "IfcPropertySingleValue",
**{"Name": name, "NominalValue": nominal_value}, **{"Name": name, "NominalValue": nominal_value},
)
) )
)
return properties return properties
def extend_pset_with_new_properties(self, new_properties): def extend_pset_with_new_properties(self, new_properties):