Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-08-28 15:53:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix BCF bug where viewpoints were not created with a .bcfv suffix which is not compliant.

Browse Source
This commit is contained in:
Dion Moult
2023-02-18 21:10:27 +11:00
parent 9cf36f1d91
commit f91e9a3119
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/bcf/src/bcf/v2/topic.py
+2 -2
View File
@@ -241,8 +241,8 @@ class TopicHandler:
self.add_visinfo_handler(vi_handler) self.add_visinfo_handler(vi_handler)
def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None:
self.viewpoints[new_viewpoint.guid] = new_viewpoint self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint
self.markup.viewpoints.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid, guid=new_viewpoint.guid)) self.markup.viewpoints.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid))
def __eq__(self, other: object) -> bool | NoReturn: def __eq__(self, other: object) -> bool | NoReturn:
return ( return (
src/bcf/src/bcf/v3/topic.py
+2 -2
View File
@@ -187,10 +187,10 @@ class TopicHandler:
self.add_visinfo_handler(vi_handler) self.add_visinfo_handler(vi_handler)
def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None: def add_visinfo_handler(self, new_viewpoint: VisualizationInfoHandler) -> None:
self.viewpoints[new_viewpoint.guid] = new_viewpoint self.viewpoints[new_viewpoint.guid + ".bcfv"] = new_viewpoint
if self.topic.viewpoints is None: if self.topic.viewpoints is None:
self.topic.viewpoints = mdl.TopicViewpoints() self.topic.viewpoints = mdl.TopicViewpoints()
self.topic.viewpoints.view_point.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid, guid=new_viewpoint.guid)) self.topic.viewpoints.view_point.append(mdl.ViewPoint(viewpoint=new_viewpoint.guid + ".bcfv", guid=new_viewpoint.guid))
def __eq__(self, other: object) -> bool | NoReturn: def __eq__(self, other: object) -> bool | NoReturn:
return ( return (