make has_started check for both pid and port

this solves the issue when a user has not killed a previous server so the port of that server wasn't removed from the pid file, which would make has_started return true even if server hasn't started yet.
fix gantt display when there are no dependencies
2026-08-07 00:11:36 +00:00 · 2024-08-15 01:24:53 +03:00 · 2024-08-15 01:24:52 +03:00 · 2024-08-15 01:24:51 +03:00 · 2024-08-15 01:24:50 +03:00 · 2024-08-15 01:24:48 +03:00
927 changed files with 152553 additions and 151177 deletions
@@ -22,7 +22,7 @@ jobs:
      - uses: actions/checkout@v2 # https://github.com/actions/checkout
      - uses: actions/setup-python@v2 # https://github.com/actions/setup-python
        with:
-          python-version: '3.11' # Version range or exact version of a Python version to use, using SemVer's version range syntax
+          python-version: '3.10' # Version range or exact version of a Python version to use, using SemVer's version range syntax
          architecture: 'x64' # optional x64 or x86. Defaults to x64 if not specified
      - run: echo ${{ env.DATE }}
      - name: Get current date
@@ -64,10 +64,7 @@ jobs:
        run: echo "version=$(cat VERSION)" >> $GITHUB_OUTPUT
      - name: Get current date
        id: date
-        # Include hours and minutes to release tag
-        # to avoid possibility of unstable repo's index.json
-        # pointing to the new file when index.json itself wasn't yet updated.
-        run: echo "date=$(date +'%y%m%d%H%M')" >> $GITHUB_OUTPUT
+        run: echo "date=$(date +'%y%m%d')" >> $GITHUB_OUTPUT
      - name: Compile
        run: |
          cd src/bonsai && make dist PLATFORM=${{ matrix.config.short_name }} PYVERSION=${{ matrix.pyver }}
@@ -145,12 +142,6 @@ jobs:
          sverchok_zip="$(pwd)/dist/$(ls dist)"
          blender --command extension install-file -r user_default $sverchok_zip

-          # Install Sun Position extension.
-          blender --online-mode --command extension sync
-          blender --online-mode --background --python-expr "import bpy; \
-          bpy.ops.extensions.package_install(repo_index=0, pkg_id='sun_position'); \
-          bpy.ops.preferences.addon_enable(module='bl_ext.blender_org.sun_position'); bpy.ops.wm.save_userpref()"
-
          cd ../bonsai
          pip install pytest-blender
          blender --background --python scripts/setup_pytest.py
@@ -24,7 +24,7 @@ jobs:
    strategy:
      fail-fast: false
      matrix:
-        pyver: [py311, py312]
+        pyver: [py310, py311, py312]
        config:
          - {
            name: "Windows Build",
@@ -32,15 +32,15 @@ jobs:
          }
          - {
            name: "Linux Build",
-            short_name: linux,
+            short_name: linux
          }
          - {
            name: "MacOS Build",
-            short_name: macos,
+            short_name: macos
          }
          - {
            name: "MacOS ARM Build",
-            short_name: macosm1,
+            short_name: macosm1
          }
    steps:
      - uses: actions/checkout@v2
@@ -53,7 +53,8 @@ jobs:
        run: echo "version=$(cat VERSION)" >> $GITHUB_OUTPUT
      - name: Compile
        run: |
-          cd src/bonsai && make dist PLATFORM=${{ matrix.config.short_name }} PYVERSION=${{ matrix.pyver }} IS_STABLE=TRUE
+          cd src/bonsai &&
+          make dist PLATFORM=${{ matrix.config.short_name }} PYVERSION=${{ matrix.pyver }} IS_STABLE=TRUE
      - name: Find zip file name
        id: find_zip
        run: |
@@ -93,7 +93,7 @@ jobs:
        lfs: true
    
    - name: Download 
-      uses: actions/download-artifact@v4.1.7
+      uses: actions/download-artifact@v2
      with:
        # Artifact name
        name: ifcos-artifacts
@@ -116,8 +116,6 @@ jobs:
      with: 
        context: artifacts
        repository: aecgeeks/ifcopenshell
-        # Since the dispatch is set to `tag`, `github.ref_name` should evaluate to the pushed tag
-        # On a workflow dispatch, `ref_name` will take on the value from the dispatch payload
-        tags: aecgeeks/ifcopenshell:${{ github.ref_name }}${{ github.ref_name == github.event.repository.default_branch && ',aecgeeks/ifcopenshell:latest' }}
+        tags: aecgeeks/ifcopenshell:latest
        file: ./Dockerfile
        push: true
@@ -73,6 +73,9 @@ src/ifcopenshell-python/test/build
 # mypy cache
 .mypy_cache

+# bonsai libs
+src/bonsai/bonsai/libs
+
 # bonsai i18n
 src/bonsai/bonsai/translations.py

@@ -12,7 +12,7 @@ is implemented for the IFC releases [IFC2x3 TC1] and [IFC4 Add2 TC1]. Extending
 is possible at compile-time when using C++ and at run-time when using Python.

 In addition to a C++ and Python API, IfcOpenShell comes with an ecosystem of tools, notably including IfcConvert (an application
-to convert IFC models to other formats), Bonsai (an add-on to Blender providing a graphical IFC authoring platform),
+to convert IFC models to other formats), the BlenderBIM Add-on (an add-on to Blender providing a graphical IFC authoring platform),
 and many other libraries, CLI apps, and more. Support is also provided for auxiliary standards such as BCF and IDS.

 For more information, see:
@@ -24,8 +24,8 @@ For more information, see:
  * [IfcOpenShell Python Hello World Tutorial](https://docs.ifcopenshell.org/ifcopenshell-python/hello_world.html)
 * [Bonsai Website](https://bonsaibim.org)
 * [Bonsai Documentation](https://docs.bonsaibim.org/index.html)
-  * [Add-on Installation](https://docs.bonsaibim.org/quickstart/installation.html)
-  * [Exploring an IFC model](https://docs.bonsaibim.org/quickstart/explore_model.html)
+  * [Add-on Installation](https://docs.bonsaibim.org/users/installation.html)
+  * [Exploring an IFC model](https://docs.bonsaibim.org/users/exploring_an_ifc_model.html)
 
 Development is sponsored through your generous donations!

@@ -36,8 +36,8 @@ Contents

 | Name                      | Description                                                           | License             | Service |
 | ------------------------- | --------------------------------------------------------------------- | ------------------- | ------- |
-| bcf                       | Library to read and write BCF-XML and query OpenCDE BCF-API modules   | LGPL-3.0-or-later   | [![PyPI](https://img.shields.io/pypi/v/bcf-client?label=PyPI&color=006dad)](https://pypi.org/project/bcf-client/) [![Anaconda-Server Badge](https://anaconda.org/conda-forge/bcf-client/badges/version.svg)](https://anaconda.org/conda-forge/bcf-client) |
-| bonsai                    | Add-on to Blender providing a graphical native IFC authoring platform | GPL-3.0-or-later    | [![Official](https://img.shields.io/badge/BonsaiBIM.org-Download-70ba35)](https://bonsaibim.org/download.html) [![GitHub Unstable](https://img.shields.io/github/v/release/ifcopenshell/ifcopenshell?filter=bonsai-*&label=GitHub-Unstable&color=f6f8fa)](https://github.com/IfcOpenShell/IfcOpenShell/releases?q=bonsai&expanded=true) [![Chocolatey](https://img.shields.io/chocolatey/v/blenderbim-nightly?label=Chocolatey&color=5c9fd8)](https://community.chocolatey.org/packages/blenderbim-nightly/) |
+| bcf                       | Library to read and write BCF-XML and query OpenCDE BCF-API modules   | LGPL-3.0-or-later   | [![PyPI](https://img.shields.io/pypi/v/bcf-client?label=PyPI&color=006dad)](https://pypi.org/project/bcf-client/) |
+| blenderbim                | Add-on to Blender providing a graphical native IFC authoring platform | GPL-3.0-or-later    | [![Official](https://img.shields.io/badge/BonsaiBIM.org-Download-70ba35)](https://bonsaibim.org/download.html) [![GitHub Unstable](https://img.shields.io/github/v/release/ifcopenshell/ifcopenshell?filter=blenderbim-*&label=GitHub-Unstable&color=f6f8fa)](https://github.com/IfcOpenShell/IfcOpenShell/releases?q=blenderbim&expanded=true) [![Chocolatey](https://img.shields.io/chocolatey/v/blenderbim-nightly?label=Chocolatey&color=5c9fd8)](https://community.chocolatey.org/packages/blenderbim-nightly/) |
 | bsdd                      | Library to query the bSDD API                                         | LGPL-3.0-or-later   | [![PyPI](https://img.shields.io/pypi/v/bsdd?label=PyPI&color=006dad)](https://pypi.org/project/bsdd/) |
 | ifc2ca                    | Utility to convert IFC structural analysis models to Code_Aster       | LGPL-3.0-or-later   |
 | ifc4d                     | Convert to and from IFC and project management software               | LGPL-3.0-or-later   | [![PyPI](https://img.shields.io/pypi/v/ifc4d?label=PyPI&color=006dad)](https://pypi.org/project/ifc4d/) |
@@ -1 +1 @@
-0.8.1
+0.7.11
@@ -27,11 +27,9 @@ if(CCACHE_FOUND)
    set_property(GLOBAL PROPERTY RULE_LAUNCH_COMPILE ccache)
 endif()

-add_definitions(-D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR)
-
 cmake_policy(SET CMP0048 NEW)
 cmake_policy(SET CMP0074 NEW)
-cmake_policy(SET CMP0078 NEW)
+cmake_policy(SET CMP0078 OLD)
 cmake_policy(SET CMP0086 NEW)
 if (POLICY CMP0144)
    cmake_policy(SET CMP0144 NEW) # find_package() uses upper-case <PACKAGENAME>_ROOT variables.
@@ -732,10 +730,6 @@ if(MSVC)
    # endif()

 	add_definitions(-D_ENABLE_EXTENDED_ALIGNED_STORAGE)
-	# See #5158.
-	if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER_EQUAL 19.40)
-		add_definitions(-D_DISABLE_CONSTEXPR_MUTEX_CONSTRUCTOR)
-	endif()
 else()
    add_definitions(-Wall -Wextra)

@@ -1051,19 +1045,10 @@ if(BUILD_CONVERT)
        target_include_directories(cityjson_converter PRIVATE ../src)
        set(IFCOPENSHELL_LIBRARIES ${IFCOPENSHELL_LIBRARIES} cityjson_converter)

-        install(TARGETS cityjson_converter
-            ARCHIVE DESTINATION ${LIBDIR}
-            LIBRARY DESTINATION ${LIBDIR}
-        )
-
        add_executable(cityjson_converter_exe ${CITYJSON_CONVERT_FILES})
        set_target_properties(cityjson_converter_exe PROPERTIES COMPILE_FLAGS "-DCITYJSON_EXECUTABLE")
        target_include_directories(cityjson_converter_exe PRIVATE ../src)
        target_link_libraries(cityjson_converter_exe ${IFCOPENSHELL_LIBRARIES} ${OPENCASCADE_LIBRARIES} ${Boost_LIBRARIES} ${HDF5_LIBRARIES} ${USD_LIBRARIES})
-
-        install(TARGETS cityjson_converter_exe
-            RUNTIME DESTINATION ${BINDIR}
-        )
    endif()

    # IfcConvert
@@ -81,7 +81,7 @@ ADD_COMMIT_SHA = os.getenv("ADD_COMMIT_SHA")
 PYTHON_VERSIONS = ["3.9.11", "3.10.3", "3.11.8", "3.12.1"]
 JSON_VERSION = "v3.6.1"
 OCE_VERSION = "0.18.3"
-OCCT_VERSION = "7.8.1"
+OCCT_VERSION = "7.7.1"
 BOOST_VERSION = "1.80.0"
 PCRE_VERSION = "8.41"
 LIBXML2_VERSION = "2.9.11"
@@ -220,7 +220,6 @@ if "v" in flags:
 else:
    logger.setLevel(logging.INFO)

-OFF_ON = ["OFF", "ON"]
 BUILD_STATIC = "shared" not in flags
 ENABLE_FLAG = "--enable-static" if BUILD_STATIC else "--enable-shared"
 DISABLE_FLAG = "--disable-shared" if BUILD_STATIC else "--disable-static"
@@ -332,7 +331,7 @@ def run_cmake(arg1, cmake_args, cmake_dir=None, cwd=None):
    if "wasm" in flags:
        wasm.append("emcmake")
        
-    run([*wasm, "cmake", P, *cmake_args, f"-DCMAKE_BUILD_TYPE={BUILD_CFG}", f"-DBUILD_SHARED_LIBS={OFF_ON[not BUILD_STATIC]}"], cwd=cwd)
+    run([*wasm, "cmake", P, *cmake_args, f"-DCMAKE_BUILD_TYPE={BUILD_CFG}"], cwd=cwd)


 def git_clone_or_pull_repository(clone_url, target_dir, revision=None):
@@ -352,8 +351,6 @@ def git_clone_or_pull_repository(clone_url, target_dir, revision=None):
        run([git, "pull", clone_url], cwd=target_dir)

    if revision != None:
-        run([git, "reset", "--hard"], cwd=target_dir)
-        run([git, "fetch", "--all"], cwd=target_dir)
        run([git, "checkout", revision], cwd=target_dir)


@@ -591,12 +588,6 @@ if USE_OCCT and "occ" in targets:
    if OCCT_VERSION == "7.7.1":
        patches.append("./patches/occt/no_ExpToCasExe.patch")
    
-    if OCCT_VERSION == "7.7.2":
-        patches.append("./patches/occt/no_ExpToCasExe_7_7_2.patch")
-
-    if OCCT_VERSION == "7.8.1":
-        patches.append("./patches/occt/no_ExpToCasExe_7_8_1.patch")
-    
    if "wasm" in flags:
        patches.append("./patches/occt/no_em_js.patch")

@@ -830,6 +821,7 @@ os.makedirs(IFCOS_DIR, exist_ok=True)
 executables_dir = os.path.join(IFCOS_DIR, "executables")
 os.makedirs(executables_dir, exist_ok=True)

+OFF_ON = ["OFF", "ON"]

 cmake_args = [
    "-DUSE_MMAP="                      "OFF",
@@ -971,7 +963,7 @@ if "IfcOpenShell-Python" in targets:

        logger.info(f"\rBuilding python {python_version} wrapper...   ")

-        run([make, f"-j{IFCOS_NUM_BUILD_PROCS}", "ifcopenshell_wrapper"], cwd=python_dir)
+        run([make, f"-j{IFCOS_NUM_BUILD_PROCS}", "_ifcopenshell_wrapper"], cwd=python_dir)
        run([make, "install/local"], cwd=os.path.join(python_dir, "ifcwrap"))

        if python_executable:
@@ -1,13 +0,0 @@
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 1bacca1a48..11f931ad39 100644
--- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -820,6 +820,8 @@ else()
-   OCCT_CHECK_AND_UNSET ("3RDPARTY_DOT_EXECUTABLE")
- endif()
- 
-+list (REMOVE_ITEM BUILD_TOOLKITS ExpToCasExe)
-+
- # bison
- if (BUILD_YACCLEX)
-   OCCT_INCLUDE_CMAKE_FILE ("adm/cmake/bison")
@@ -1,13 +0,0 @@
-diff --git a/CMakeLists.txt b/CMakeLists.txt
-index 86905287dc..9d0bce984c 100644
--- a/CMakeLists.txt
-+++ b/CMakeLists.txt
-@@ -828,6 +828,8 @@ else()
-   OCCT_CHECK_AND_UNSET ("3RDPARTY_DOT_EXECUTABLE")
- endif()
- 
-+list (REMOVE_ITEM BUILD_TOOLKITS ExpToCasExe)
-+
- # bison
- if (BUILD_YACCLEX)
-   OCCT_INCLUDE_CMAKE_FILE ("adm/cmake/bison")
@@ -4,7 +4,7 @@ include = '''
    src/(
        bcf
        |bcfserver
-        |bonsai
+        |blenderbim
        |bsdd
        |foundationserver
        |ifc2ca
@@ -1,10 +0,0 @@
-import bcf.v2.model
-import bcf.v3.model
-from typing import Union
-
-BimSnippet = Union[bcf.v2.model.BimSnippet, bcf.v3.model.BimSnippet]
-BitMap = Union[bcf.v2.model.VisualizationInfoBitmap, bcf.v3.model.Bitmap]
-DocumentReference = Union[bcf.v2.model.TopicDocumentReference, bcf.v3.model.DocumentReference]
-HeaderFile = Union[bcf.v2.model.HeaderFile, bcf.v3.model.File]
-Topic = Union[bcf.v2.model.Topic, bcf.v3.model.Topic]
-ViewPoint = Union[bcf.v2.model.ViewPoint, bcf.v3.model.ViewPoint]
@@ -1,101 +0,0 @@
-import tempfile
-import bcf.v2.bcfxml
-import bcf.v2.model
-import bcf.v2.topic
-import bcf.v3.bcfxml
-import bcf.v3.model
-import bcf.v3.topic
-import bcf.agnostic.model as mdl
-from pathlib import Path
-from typing import Union, Optional
-from typing_extensions import assert_never
-
-TopicHandler = Union[bcf.v2.topic.TopicHandler, bcf.v3.topic.TopicHandler]
-
-
-def extract_file(
-    topic: TopicHandler,
-    entity: Union[mdl.HeaderFile, mdl.BimSnippet, mdl.DocumentReference, mdl.BitMap],
-    bcfxml: Optional[Union[bcf.v2.bcfxml.BcfXml, bcf.v3.bcfxml.BcfXml]] = None,
-    outfile: Optional[Path] = None,
-) -> Union[Path, str, None]:
-    """Extracts an element with a file into a temporary directory
-
-    These include header files, bim snippets, document references, and
-    viewpoint bitmaps. External reference are not downloaded. Instead, the
-    URI reference is returned.
-
-    :param entity: The entity with a file reference to extract
-    :param outfile: If provided, save the header file to that location.
-        Otherwise, a temporary directory is created and the filename is
-        derived from the header's original filename.
-    :param bcfxml: The BCF XML file to use for resolving document references files.
-        Required only for BCF v3 document references (in BCF v3 internal documents
-        are stored at BCF root, not in the topic).
-    :return: The filepath of the extracted file. It may be a URL if the
-        header file is external.
-    """
-    if isinstance(entity, mdl.DocumentReference):
-        if isinstance(entity, bcf.v2.model.TopicDocumentReference):
-            reference = entity.referenced_document
-        else:
-            reference = entity.document_guid
-    else:
-        reference = entity.reference
-
-    if not reference:
-        return None
-
-    # For v3 document references external documents are detected by empty document_guid.
-    # External bitmaps are not supported by bcf.
-    if not isinstance(entity, (bcf.v3.model.DocumentReference, mdl.BitMap)) and entity.is_external:
-        return reference
-
-    if isinstance(entity, bcf.v3.model.DocumentReference):
-        # Extract document reference filename and contents.
-        if not bcfxml:
-            raise TypeError("bcfxml is required for BCF v3 document references.")
-        assert isinstance(bcfxml, bcf.v3.bcfxml.BcfXml)
-        error_msg = f"BCF XML is missing document with guid '{reference}'."
-        if not bcfxml.documents:
-            raise Exception(error_msg)
-        definition_docs = bcfxml.documents.definition.documents
-        if not definition_docs:
-            raise Exception(error_msg)
-        docs = next((doc for doc in definition_docs.document if doc.guid == reference), None)
-        if not docs:
-            raise Exception(error_msg)
-        filename = docs.filename
-        bytes_data = bcfxml.documents.documents[filename]
-    else:
-        if isinstance(entity, mdl.BimSnippet):
-            bytes_data = topic.bim_snippet
-            assert isinstance(bytes_data, bytes)
-        elif isinstance(entity, mdl.HeaderFile):
-            bytes_data = topic.reference_files[reference]
-        elif isinstance(entity, mdl.BitMap):
-            bytes_data = next(
-                byte_data
-                for vp in topic.viewpoints.values()
-                for data_reference, byte_data in vp.bitmaps.items()
-                if data_reference == reference
-            )
-        elif isinstance(entity, bcf.v2.model.TopicDocumentReference):
-            assert isinstance(topic, bcf.v2.topic.TopicHandler)
-            bytes_data = topic.document_references[reference]
-        else:
-            assert_never(entity)
-
-        # We don't really need it if 'outfile' is None, just keeping type checker happy.
-        if isinstance(entity, mdl.HeaderFile) and entity.filename:
-            filename = entity.filename
-        else:
-            filename = Path(reference).name
-
-    if not outfile:
-        outfile = Path(tempfile.mkdtemp()) / filename
-
-    with open(outfile, "wb") as f:
-        f.write(bytes_data)
-
-    return outfile
@@ -1,5 +0,0 @@
-import bcf.v2.visinfo
-import bcf.v3.visinfo
-from typing import Union
-
-VisualizationInfoHandler = Union[bcf.v2.visinfo.VisualizationInfoHandler, bcf.v3.visinfo.VisualizationInfoHandler]
@@ -63,21 +63,11 @@ class TopicHandler:
        """Return the header of the topic."""
        return self.markup.header if self.markup else None

-    @header.setter
-    def header(self, header: mdl.Header) -> None:
-        """Set the header of the topic."""
-        self.markup.header = header
-
    @property
    def comments(self) -> list[mdl.Comment]:
        """Return the comments of the topic."""
        return self.markup.comment if self.markup else []

-    @comments.setter
-    def comments(self, comments: list[mdl.Comment]) -> None:
-        assert self.markup
-        self.markup.comment = comments
-
    @property
    def bim_snippet(self) -> Optional[bytes]:
        if not self._bim_snippet and self._topic_dir:
@@ -240,6 +230,54 @@ class TopicHandler:
                real_path = real_path.parent if path_part == ".." else real_path.joinpath(path_part)
            destination_zip.writestr(real_path.at, self.document_references[doc.referenced_document])

+    def extract_file(
+        self, entity: Union[mdl.HeaderFile, mdl.BimSnippet, mdl.TopicDocumentReference], outfile: Optional[Path] = None
+    ) -> Union[Path, str, None]:
+        """Extracts an element with a file into a temporary directory
+
+        These include header files, bim snippets, document references, and
+        viewpoint bitmaps. External reference are not downloaded. Instead, the
+        URI reference is returned.
+
+        :param entity: The entity with a file reference to extract
+        :param outfile: If provided, save the header file to that location.
+            Otherwise, a temporary directory is created and the filename is
+            derived from the header's original filename.
+        :return: The filepath of the extracted file. It may be a URL if the
+            header file is external.
+        :rtype: Path
+        """
+        if hasattr(entity, "reference"):
+            reference = entity.reference
+        else:
+            reference = entity.referenced_document
+
+        if not reference:
+            return
+
+        if getattr(entity, "is_external", False):
+            return entity.reference
+
+        resolved_reference = self._topic_dir
+
+        for part in Path(reference).parts:
+            if part == "..":
+                resolved_reference = resolved_reference.parent
+            else:
+                resolved_reference = resolved_reference.joinpath(part)
+
+        if not outfile:
+            if getattr(entity, "filename", None):
+                filename = entity.filename
+            else:
+                filename = resolved_reference.name
+            outfile = Path(tempfile.mkdtemp()) / filename
+
+        with open(outfile, "wb") as f:
+            f.write(resolved_reference.read_bytes())
+
+        return outfile
+
    def add_viewpoint(self, element: entity_instance) -> VisualizationInfoHandler:
        """Add a viewpoint pointed at the placement of an IFC element to the topic.

@@ -27,7 +27,6 @@ class TopicHandler:
    ) -> None:
        self._markup: Optional[mdl.Markup] = None
        self._viewpoints: Optional[dict[str, VisualizationInfoHandler]] = None
-        self._reference_files: Optional[dict[str, bytes]] = None
        self._bim_snippet: Optional[bytes] = None
        self._xml_handler = xml_handler or XmlParserSerializer()
        self._topic_dir = topic_dir
@@ -50,36 +49,22 @@ class TopicHandler:
        return self.markup.topic

    @property
-    def guid(self) -> str:
+    def guid(self) -> Optional[str]:
        """Return the GUID of the topic."""
        if self._markup:
            return self.topic.guid
-        return self._topic_dir.name if self._topic_dir else ""
+        return self._topic_dir.name if self._topic_dir else None

    @property
    def header(self) -> Optional[mdl.Header]:
        """Return the header of the topic."""
        return self.markup.header

-    @header.setter
-    def header(self, header: mdl.Header) -> None:
-        """Set the header of the topic."""
-        self.markup.header = header
-
    @property
    def comments(self) -> list[mdl.Comment]:
        """Return the comments of the topic."""
        return self.topic.comments.comment if self.topic.comments else []

-    @comments.setter
-    def comments(self, comments: list[mdl.Comment]) -> None:
-        topic_comments = self.topic.comments
-        if topic_comments is None:
-            if not comments:
-                return
-            self.topic.comments = (topic_comments := mdl.TopicComments())
-        topic_comments.comment = comments
-
    @property
    def bim_snippet(self) -> Optional[bytes]:
        if not self._bim_snippet and self._topic_dir:
@@ -109,27 +94,6 @@ class TopicHandler:
                return bim_snippet_path.read_bytes()
        return None

-    @property
-    def reference_files(self) -> dict[str, bytes]:
-        if self._reference_files is not None:
-            return self._reference_files
-
-        self._reference_files = {}
-        if not self.header:
-            return self._reference_files
-
-        if not self.header.files:
-            return self._reference_files
-
-        for ref in self.header.files.file:
-            if ref.is_external:
-                continue
-            real_path = self._topic_dir
-            for path_part in ref.reference.split("/"):
-                real_path = real_path.parent if path_part == ".." else real_path.joinpath(path_part)
-            self._reference_files[ref.reference] = real_path.read_bytes()
-        return self._reference_files
-
    @classmethod
    def create_new(
        cls,
@@ -181,7 +145,6 @@ class TopicHandler:
        self._save_xml(destination_zip, self._markup, "markup.bcf")
        self._save_viewpoints(destination_zip, topic_dir)
        self._save_bim_snippet(destination_zip)
-        self._save_reference_files(destination_zip)

    def _save_viewpoints(self, destination_zip: ZipFileInterface, topic_dir: str) -> None:
        if not self.topic.viewpoints or not (viewpoints := self.topic.viewpoints.view_point):
@@ -202,19 +165,6 @@ class TopicHandler:
        if self.bim_snippet:
            destination_zip.writestr(f"{self.topic.guid}/{ref_filename}", self.bim_snippet)

-    def _save_reference_files(self, destination_zip: ZipFileInterface) -> None:
-        if not self.header:
-            return
-        if not self.header.files:
-            return
-        for ref in self.header.files.file:
-            if ref.is_external or not ref.reference:
-                continue
-            real_path = self._topic_dir
-            for path_part in ref.reference.split("/"):
-                real_path = real_path.parent if path_part == ".." else real_path.joinpath(path_part)
-            destination_zip.writestr(real_path.at, self.reference_files[ref.reference])
-
    def add_viewpoint(self, element: entity_instance) -> VisualizationInfoHandler:
        """
        Add a viewpoint tergeting an IFC element to the topic.
@@ -66,11 +66,7 @@ BLENDER_PLATFORM:=linux-x64
 endif

 ifeq ($(PLATFORM), macos)
-ifeq ($(PYVERSION), py311)
 PYPI_PLATFORM:=--platform macosx_10_10_x86_64
-else
-PYPI_PLATFORM:=--platform macosx_10_13_x86_64
-endif
 BLENDER_PLATFORM:=macos-x64
 endif

@@ -85,12 +81,9 @@ BLENDER_PLATFORM:=windows-x64
 endif

 # Current build commit hash.
-OLD:=0e5008d
+OLD:=d51fa2c
 .PHONY: bump
 bump:
-ifndef NEW
-	$(error ERROR: 'NEW' variable is not set (should be set with new commmit hash). Example use for 'bump' command: 'make bump NEW=0123456'.)
-endif
 	cd . && $(SED) -b "s/$(OLD)/$(NEW)/" Makefile
 	cd ../ifcopenshell-python/ && $(SED) -b "s/$(OLD)/$(NEW)/" Makefile

@@ -137,8 +130,6 @@ endif
 	cd build && . env/$(VENV_ACTIVATE) && $(PIP) wheel odfpy --wheel-dir=./wheels
 	# Required by IFCCityJSON
 	cd build && . env/$(VENV_ACTIVATE) && $(PIP) download cjio --dest=./wheels
-	# Required in general for sorting all sorts of stuff in a nice way
-	cd build && . env/$(VENV_ACTIVATE) && $(PIP) download natsort --dest=./wheels
 	# Provides express rule validation for ifcopenshell.validate
 	cd build && . env/$(VENV_ACTIVATE) && $(PIP) download pytest --dest=./wheels
 	# Provides Brickschema functionality
@@ -274,13 +265,18 @@ endif
 	# See: https://projects.blender.org/blender/blender/issues/125091

 ifeq ($(PLATFORM), macosm1)
+	# Has universal and x86_64 builds.
+	prev_whl_name=$$(find build/bonsai/wheels/MarkupSafe-*.whl); \
+	whl_name=$$(echo $$prev_whl_name | sed "s/_universal2/_arm64/"); \
+	mv "$$prev_whl_name" "$$whl_name";
+
 	# Has universal and x86_64 builds.
 	prev_whl_name=$$(find build/bonsai/wheels/lxml-*.whl); \
 	whl_name=$$(echo $$prev_whl_name | sed "s/_universal2/_arm64/"); \
 	mv "$$prev_whl_name" "$$whl_name";

 	prev_whl_name=$$(find build/bonsai/wheels/tzfpy-*.whl); \
-	whl_name=$$(echo $$prev_whl_name | sed -E "s/macosx_10_([0-9]+)_x86_64\.macosx_11_0_arm64\.macosx_10_\1_universal2/macosx_10_\1_arm64/"); \
+	whl_name=$$(echo $$prev_whl_name | sed "s/macosx_10_12_x86_64.macosx_11_0_arm64.macosx_10_12_universal2/macosx_10_12_arm64/"); \
 	mv "$$prev_whl_name" "$$whl_name";

 	# Has only universal build.
@@ -289,20 +285,15 @@ ifeq ($(PLATFORM), macosm1)
 	mv "$$prev_whl_name" "$$whl_name";
 endif
 ifeq ($(PLATFORM), macos)
-	# Has universal and arm64 builds.
-	prev_whl_name=$$(find build/bonsai/wheels/MarkupSafe-*.whl); \
-	whl_name=$$(echo $$prev_whl_name | sed "s/_universal2/_x86_64/"); \
-	mv "$$prev_whl_name" "$$whl_name";
-
 	prev_whl_name=$$(find build/bonsai/wheels/tzfpy-*.whl); \
-	whl_name=$$(echo $$prev_whl_name | sed -E "s/macosx_10_([0-9]+)_x86_64\.macosx_11_0_arm64\.macosx_10_\1_universal2/macosx_10_\1_x86_64/"); \
+	whl_name=$$(echo $$prev_whl_name | sed "s/macosx_10_9_x86_64.macosx_11_0_arm64.macosx_10_9_universal2/macosx_10_9_x86_64/"); \
 	mv "$$prev_whl_name" "$$whl_name";

 	prev_whl_name=$$(find build/bonsai/wheels/greenlet-*.whl); \
 	whl_name=$$(echo $$prev_whl_name | sed "s/_universal2/_x86_64/"); \
 	mv "$$prev_whl_name" "$$whl_name";

-	# has universal and arm builds.
+	# has universal and amr64 builds.
 	prev_whl_name=$$(find build/bonsai/wheels/fonttools-*.whl); \
 	whl_name=$$(echo $$prev_whl_name | sed "s/_universal2/_x86_64/"); \
 	mv "$$prev_whl_name" "$$whl_name";
@@ -56,10 +56,9 @@ bbim_semver: dict[str, Any] = {}

 # Accessed from bonsai dependency:
 last_error = None
-last_actions: deque = deque(maxlen=20)
+last_actions: deque = deque(maxlen=10)
 FIRST_INSTALLED_BBIM_VERSION: Union[str, None] = None
 REINSTALLED_BBIM_VERSION: Union[str, None] = None
-REGISTERED_BBIM_PACKAGE: str


 def initialize_bbim_semver():
@@ -239,10 +238,6 @@ if IN_BLENDER:
            if platform.system() == "Windows":
                clean_up_dlls_safe_links()

-            import bonsai
-
-            bonsai.REGISTERED_BBIM_PACKAGE = __package__
-
            import bonsai.bim

            current_version = bbim_semver["version"]
@@ -329,7 +324,7 @@ if IN_BLENDER:

                layout.operator("bim.copy_debug_information", text="Copy Error Message To Clipboard")
                op = layout.operator("bim.open_uri", text="How Can I Fix This?")
-                op.uri = "https://docs.bonsaibim.org/guides/troubleshooting.html#installation-issues"
+                op.uri = "https://docs.bonsaibim.org/users/troubleshooting.html#installation-issues"

                layout.label(text="Try Reinstalling:", icon="IMPORT")
                op = layout.operator("bim.open_uri", text="Re-download Add-on")
@@ -144,7 +144,7 @@ classes = [
    # Project overview
    ui.BIM_PT_tab_new_project_wizard,
    ui.BIM_PT_tab_project_info,
-    ui.BIM_PT_tab_spatial,
+    ui.BIM_PT_tab_spatial_decomposition,
    ui.BIM_PT_tab_project_setup,
    ui.BIM_PT_tab_geometry,
    ui.BIM_PT_tab_stakeholders,
@@ -1 +0,0 @@
-This cache folder contains .h5 files. These files cache IFC geometry for performance only. You may safely clear the contents of this cache folder without losing data.
@@ -1,3 +1,2 @@
 *
 !.gitignore
-!README.md
--- a/Show More
+++ b/Show More
Author	SHA1	Message	Date
Ziad-I	9aba274070	make has_started check for both pid and port this solves the issue when a user has not killed a previous server so the port of that server wasn't removed from the pid file, which would make has_started return true even if server hasn't started yet.	2024-08-15 01:24:53 +03:00
Ziad-I	3b7d44a1c6	fix gantt display when there are no dependencies	2024-08-15 01:24:52 +03:00
Ziad-I	bf722ecfe3	fix setting color-scheme css property	2024-08-15 01:24:51 +03:00
Ziad-I	61cff3df43	edit names of pages and paths for them	2024-08-15 01:24:50 +03:00
Ziad-I	8b4b1da8a4	docstrings and formating	2024-08-15 01:24:48 +03:00
Ziad-I	69997bf9d8	add open different web UI pages on starting it up	2024-08-15 01:24:47 +03:00
Ziad-I	53907accd9	make webui default for work schedules and simplfy condition	2024-08-15 01:24:45 +03:00
Ziad-I	a4f881517b	fix dependency display bug dependency was not being displayed correctly due to calling draw on Gantt before appending it to the DOM, I think?	2024-08-15 01:24:44 +03:00
Ziad-I	8acaf0ff26	edit condition if user tries to export to web with no server previously it was just checking if there was a server running but not if blender was connected to a server, this was being handled in the operator itself which isn't the best.	2024-08-15 01:24:43 +03:00
Ziad-I	105bfb5647	make web default format when exporting	2024-08-15 01:24:42 +03:00
Ziad-I	866e3b0f66	handle edge case not covered by last commit	2024-08-15 01:24:40 +03:00
Ziad-I	79d6801315	fix error when exporting an empty csv	2024-08-15 01:24:39 +03:00
Ziad-I	a2539b659f	split addGanttElement function into smaller functions for code organization and readability	2024-08-15 01:24:38 +03:00
Ziad-I	3e154b6344	fix printing when there is multiple gantt charts	2024-08-15 01:24:37 +03:00
Ziad-I	c1fa735f9c	edit or commented left over console.log	2024-08-15 01:24:35 +03:00
Ziad-I	9e5f73701c	fix connected list appearing in printing	2024-08-15 01:24:34 +03:00
Ziad-I	7fa8ebfbd1	add different bg color for work schedule table rows	2024-08-15 01:24:33 +03:00
Ziad-I	d47e5c1167	move outdated gantt warning into connected list	2024-08-15 01:24:32 +03:00
Ziad-I	d142fa5e62	move outdated data warning into connected list for csv page	2024-08-15 01:24:30 +03:00
Ziad-I	27ef2b5d49	change used text color for warnings	2024-08-15 01:24:29 +03:00
@@ -1 +1 @@
 .8.1
 .7.11
				`@@ -1 +0,0 @@`
				`This cache folder contains .h5 files. These files cache IFC geometry for performance only. You may safely clear the contents of this cache folder without losing data.`