mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-06 07:51:47 +00:00
Petru Conduraru
d053530743
A second, independent trigger for the MakePipeShell hang from #8400: a kink angle at a directrix joint in roughly the 0.57-5 degree band produces two nearly-coaxial pipe surfaces at the corner, and BRepFill_TrimShellCorner's projection (ProjLib_CompProjectedCurve::Init) never converges. This happens regardless of chord length, so the sub-radius chord collapse already fixed in the directrix-hang commit does not prevent it. BRepOffsetAPI_MakePipeShell::SetTransitionMode always leaves Angmin (the kink angle below which OCCT treats a joint as a safe butt-join rather than routing it through the corner trim) at its hardcoded default of 1e-2 rad, and does not expose a way to change it. Confirmed by pulling the OCCT 7.9.2 source: the wrapper is a 1:1 forwarding layer over BRepFill_PipeShell (same Add/Set/Build/ FirstShape/LastShape/Shape semantics), and its own Build() discards the Message_ProgressRange argument it declares, so no progress/cancellation signal reaches this path either way. Switch to BRepFill_PipeShell directly and raise Angmin to 0.1 rad (~5.7 deg) so the dangerous band takes the butt-join path. Verified against the reporter's minimal repro (IfcCableCarrierSegment, 101- segment composite curve directrix, disk radius 1.6cm, kink angles 0.15-2 deg): clean v0.8.0 and v0.8.0 with only the prior directrix-collapse fix both still hang (30s+ timeout, matches the reported bug); with this change it converts in ~1s (4781 verts, 5684 faces, no validation errors). Independently bisected the Angmin threshold on this repro: 0.02 rad still hangs, 0.06 rad fails cleanly ("BRep_API: command not done", no hang), 0.1 rad converges. Regression-checked all 50 test/input fixtures containing IfcSweptDiskSolid (the ones parseable under this build's IFC4-only schema config produce identical exit codes and, where conversion succeeds outright, identical output, before and after) and a synthetic 30 degree corner (well above the new threshold): byte-identical output, confirming ordinary corners are unaffected. One real fixture (987--cableSegment) has joints that fall in the newly-affected band and now converts with fewer vertices/faces at those corners (butt-join instead of trim); both variants pass --validate with no errors, and nearest-neighbour vertex deviation between the two outputs peaks under 1mm on a 3.9mm-radius cable, i.e. a real but small and bounded fidelity trade at corners that previously could hang forever. Generated with the assistance of an AI coding tool.
IfcOpenShell
IfcOpenShell is an open source (LGPL) software library for working with Industry Foundation Classes (IFC). Complete parsing support is provided for IFC2x3 TC1, IFC4 Add2 TC1, IFC4x1, IFC4x2, and IFC4x3 Add2. Extensive geometric support is implemented for the IFC releases IFC2x3 TC1 and IFC4 Add2 TC1. Extending with support for arbitrary IFC schemas is possible at compile-time when using C++ and at run-time when using Python.
In addition to a C++ and Python API, IfcOpenShell comes with an ecosystem of tools, notably including IfcConvert (an application to convert IFC models to other formats), Bonsai (an add-on to Blender providing a graphical IFC authoring platform), and many other libraries, CLI apps, and more. Support is also provided for auxiliary standards such as BCF and IDS.
For more information, see:
Development is sponsored through your generous donations!
Contents
| Name | Description | License | Service |
|---|---|---|---|
| bcf | Library to read and write BCF-XML and query OpenCDE BCF-API modules | LGPL-3.0-or-later |   |
| bonsai | Add-on to Blender providing a graphical native IFC authoring platform | GPL-3.0-or-later |    |
| bsdd | Library to query the bSDD API | LGPL-3.0-or-later |  |
| ifc2ca | Utility to convert IFC structural analysis models to Code_Aster | LGPL-3.0-or-later | |
| ifc4d | Convert to and from IFC and project management software | LGPL-3.0-or-later |  |
| ifc5d | Report and optimise cost information from IFC | LGPL-3.0-or-later |  |
| ifcbimtester | Wrapper for Gherkin based unit testing for IFC models | LGPL-3.0-or-later | |
| ifcblender | Historic Blender IFC import add-on | LGPL-3.0-or-later* | |
| ifccityjson | Convert CityJSON to IFC | LGPL-3.0-or-later |  |
| ifcclash | Clash detection library and CLI app | LGPL-3.0-or-later |  |
| ifcconvert | CLI app to convert IFC to many other formats | LGPL-3.0-or-later* |   |
| ifccsv | Library and CLI app to export and import schedules from IFC | LGPL-3.0-or-later |  |
| ifcdiff | Compare changes between IFC models | LGPL-3.0-or-later |  |
| ifcedit | CLI wrapper for ifcopenshell.api IFC model mutation functions | LGPL-3.0-or-later |  |
| ifcfm | Extract IFC data for FM handover requirements | LGPL-3.0-or-later |  |
| ifcmax | Historic extension for IFC support in 3DS Max | LGPL-3.0-or-later* | |
| ifcmcp | MCP server for querying and editing IFC building models | LGPL-3.0-or-later |  |
| ifcopenshell-python | Python library for IFC manipulation | LGPL-3.0-or-later* |         |
| ifcpatch | Utility to run pre-packaged scripts to manipulate IFCs | LGPL-3.0-or-later |  |
| ifcquery | CLI tool for querying and inspecting IFC building models | LGPL-3.0-or-later |  |
| ifcsverchok | Blender Add-on for visual node programming with IFC | GPL-3.0-or-later |  |
| ifctester | Library, CLI and webapp for IDS model auditing | LGPL-3.0-or-later |  |
The IfcOpenShell C++ codebase is split into multiple interal libraries:
| Name | Description | License |
|---|---|---|
| ifcgeom | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcgeom_schema_agnostic | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcgeomserver | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcjni | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcparse | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcwrap | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| qtviewer | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| serializers | Internal library for IfcOpenShell | LGPL-3.0-or-later* |