mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-05 23:41:44 +00:00
Petru Conduraru
be1ccbc88c
CgalKernel::convert_impl(taxonomy::boolean_result) skipped a base
operand via a bare continue whenever preprocess_boolean_operand()
rejected it (self-intersecting, not closed, etc.), without recording
that the accumulator `a` never got its first Nef polyhedron. For
SUBTRACTION and INTERSECTION, later operands were then combined
against that empty, uninitialized `a`, and the function still
returned true. The net effect was a boolean_result silently producing
empty-but-"successful" geometry, and, under a hybrid kernel chain, no
escalation to the next kernel since CgalKernel itself reported success.
Reproduced with a synthetic closed solid whose faces are each
individually simple/planar but whose sides cross in 3D (self-
intersecting overall), used as the first operand of an
IfcBooleanResult DIFFERENCE:
kernel | before | after
opencascade | 136 v | 136 v (unchanged)
cgal | 0 v | 0 v, now with a logged
GEO105 failure instead of
a silent "success"
hybrid-cgal-opencascade | 0 v | 136 v (escalates to OCCT,
matches plain opencascade)
hybrid-cgal-simple-opencascade | 136 v | 136 v (unaffected; cgal-
simple already can't do
booleans and always yields)
Same result for a non-closed self-intersecting-loop variant (an
IfcBooleanClippingResult roof-style cut) and for a plain box second
operand instead of a half-space.
Now `a` is only combined into once the base operand has actually
contributed a Nef polyhedron; if it never does, the whole boolean
fails outright rather than emitting wrong-but-successful geometry.
UNION is left untouched: it is commutative, so whichever operand
succeeds first already becomes a correct seed for `a`.
Regression: full sweep of test/input (258 fixtures) under both
`cgal` and `hybrid-cgal-opencascade`, baseline vs patched, output
byte-compared. 254-255/258 identical per kernel; the handful of
diffs (539--rotated-studs--augmented.ifc, large_offset.ifc,
TestModel_IFC4Add2.ifc, WallInstance_IFC4Add2.ifc) reproduce
identically when the unpatched baseline is run against itself twice,
i.e. pre-existing nondeterminism, not caused by this change.
Related to #8793 and #8814, which independently flagged this same
`continue` as a suspected but unconfirmed defect. This does not
touch #8793's separate shell/solid escalation path.
Generated with the assistance of an AI coding tool.
IfcOpenShell
IfcOpenShell is an open source (LGPL) software library for working with Industry Foundation Classes (IFC). Complete parsing support is provided for IFC2x3 TC1, IFC4 Add2 TC1, IFC4x1, IFC4x2, and IFC4x3 Add2. Extensive geometric support is implemented for the IFC releases IFC2x3 TC1 and IFC4 Add2 TC1. Extending with support for arbitrary IFC schemas is possible at compile-time when using C++ and at run-time when using Python.
In addition to a C++ and Python API, IfcOpenShell comes with an ecosystem of tools, notably including IfcConvert (an application to convert IFC models to other formats), Bonsai (an add-on to Blender providing a graphical IFC authoring platform), and many other libraries, CLI apps, and more. Support is also provided for auxiliary standards such as BCF and IDS.
For more information, see:
Development is sponsored through your generous donations!
Contents
| Name | Description | License | Service |
|---|---|---|---|
| bcf | Library to read and write BCF-XML and query OpenCDE BCF-API modules | LGPL-3.0-or-later |   |
| bonsai | Add-on to Blender providing a graphical native IFC authoring platform | GPL-3.0-or-later |    |
| bsdd | Library to query the bSDD API | LGPL-3.0-or-later |  |
| ifc2ca | Utility to convert IFC structural analysis models to Code_Aster | LGPL-3.0-or-later | |
| ifc4d | Convert to and from IFC and project management software | LGPL-3.0-or-later |  |
| ifc5d | Report and optimise cost information from IFC | LGPL-3.0-or-later |  |
| ifcbimtester | Wrapper for Gherkin based unit testing for IFC models | LGPL-3.0-or-later | |
| ifcblender | Historic Blender IFC import add-on | LGPL-3.0-or-later* | |
| ifccityjson | Convert CityJSON to IFC | LGPL-3.0-or-later |  |
| ifcclash | Clash detection library and CLI app | LGPL-3.0-or-later |  |
| ifcconvert | CLI app to convert IFC to many other formats | LGPL-3.0-or-later* |   |
| ifccsv | Library and CLI app to export and import schedules from IFC | LGPL-3.0-or-later |  |
| ifcdiff | Compare changes between IFC models | LGPL-3.0-or-later |  |
| ifcedit | CLI wrapper for ifcopenshell.api IFC model mutation functions | LGPL-3.0-or-later |  |
| ifcfm | Extract IFC data for FM handover requirements | LGPL-3.0-or-later |  |
| ifcmax | Historic extension for IFC support in 3DS Max | LGPL-3.0-or-later* | |
| ifcmcp | MCP server for querying and editing IFC building models | LGPL-3.0-or-later |  |
| ifcopenshell-python | Python library for IFC manipulation | LGPL-3.0-or-later* |         |
| ifcpatch | Utility to run pre-packaged scripts to manipulate IFCs | LGPL-3.0-or-later |  |
| ifcquery | CLI tool for querying and inspecting IFC building models | LGPL-3.0-or-later |  |
| ifcsverchok | Blender Add-on for visual node programming with IFC | GPL-3.0-or-later |  |
| ifctester | Library, CLI and webapp for IDS model auditing | LGPL-3.0-or-later |  |
The IfcOpenShell C++ codebase is split into multiple interal libraries:
| Name | Description | License |
|---|---|---|
| ifcgeom | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcgeom_schema_agnostic | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcgeomserver | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcjni | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcparse | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| ifcwrap | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| qtviewer | Internal library for IfcOpenShell | LGPL-3.0-or-later* |
| serializers | Internal library for IfcOpenShell | LGPL-3.0-or-later* |