Petru Conduraru 57cfd9d1fd Fix #1043. Optimise IfcPatch recipe: avoid redundant recursive get_info
The 2020 profiling in issue #1043 found the Optimise recipe's dedup
loop spent almost all of its time in entity_instance.get_info(recursive=True):
because the topological sort already guarantees every referenced entity
is folded before the entity that references it, recomputing each
already-folded subtree's canonical value from scratch for every parent
that points to it is wasted work. Confirmed this is still exactly the
bottleneck in the current codebase, unchanged since 2020 (get_info's
recursive path still walks the whole subtree on every call).

Applied aothms's suggested fix from the issue thread: canonicalize each
entity with a non-recursive get_info, and for referenced entities substitute
the already-computed identity of their folded replacement (looked up in
instance_mapping) instead of re-expanding the subtree. Also limited the
toposort dependency graph to direct references (max_levels=1), since a
topological sort only needs direct edges, not the full transitive closure
traverse() was computing for every entity.

Benchmarked before and after on real IFC test fixtures and a larger
synthetic file with heavily shared geometry (thousands of walls sharing
a handful of profile/point subtrees, mirroring the sharing pattern
described in the issue):

- test/input/geometrygym_great_court_roof.ifc (56989 entities): 9.9s -> 1.7s
- test/input/acad2010_objects.ifc (16296 entities): 3.7s -> 0.4s
- synthetic 120083-entity fixture with heavy geometry sharing: 19.2s -> 3.4s

Verified correctness by comparing the full canonical (recursive get_info)
multiset of the optimized output between the old and new implementation on
all three fixtures: identical results, same fold counts.

Added test_Optimise.py covering the core scenario from the issue: entities
built from separate, value-identical non-rooted subtrees fold to a shared
instance, while entities with distinct values do not.

Generated with the assistance of an AI coding tool.
2026-07-18 22:13:29 +02:00
2025-12-19 18:53:14 +05:00
2025-12-19 18:53:14 +05:00
2026-01-26 17:10:03 +05:00
2026-07-18 22:39:33 +05:00
2026-04-26 21:29:16 +02:00
2026-01-26 17:10:02 +05:00
2023-09-14 09:29:20 +02:00
2026-02-18 09:09:46 +11:00
2025-08-28 20:05:45 +02:00
2025-08-28 20:05:45 +02:00
2026-07-18 22:39:33 +05:00
2026-04-13 19:40:25 +05:00

IfcOpenShell

IfcOpenShell is an open source (LGPL) software library for working with Industry Foundation Classes (IFC). Complete parsing support is provided for IFC2x3 TC1, IFC4 Add2 TC1, IFC4x1, IFC4x2, and IFC4x3 Add2. Extensive geometric support is implemented for the IFC releases IFC2x3 TC1 and IFC4 Add2 TC1. Extending with support for arbitrary IFC schemas is possible at compile-time when using C++ and at run-time when using Python.

In addition to a C++ and Python API, IfcOpenShell comes with an ecosystem of tools, notably including IfcConvert (an application to convert IFC models to other formats), Bonsai (an add-on to Blender providing a graphical IFC authoring platform), and many other libraries, CLI apps, and more. Support is also provided for auxiliary standards such as BCF and IDS.

For more information, see:

Development is sponsored through your generous donations!

Open Collective Contributors

Contents

Name Description License Service
bcf Library to read and write BCF-XML and query OpenCDE BCF-API modules LGPL-3.0-or-later PyPI Anaconda-Server Badge
bonsai Add-on to Blender providing a graphical native IFC authoring platform GPL-3.0-or-later Official GitHub Unstable Chocolatey
bsdd Library to query the bSDD API LGPL-3.0-or-later PyPI
ifc2ca Utility to convert IFC structural analysis models to Code_Aster LGPL-3.0-or-later
ifc4d Convert to and from IFC and project management software LGPL-3.0-or-later PyPI
ifc5d Report and optimise cost information from IFC LGPL-3.0-or-later PyPI
ifcbimtester Wrapper for Gherkin based unit testing for IFC models LGPL-3.0-or-later
ifcblender Historic Blender IFC import add-on LGPL-3.0-or-later*
ifccityjson Convert CityJSON to IFC LGPL-3.0-or-later PyPI
ifcclash Clash detection library and CLI app LGPL-3.0-or-later PyPI
ifcconvert CLI app to convert IFC to many other formats LGPL-3.0-or-later* Official GitHub
ifccsv Library and CLI app to export and import schedules from IFC LGPL-3.0-or-later PyPI
ifcdiff Compare changes between IFC models LGPL-3.0-or-later PyPI
ifcedit CLI wrapper for ifcopenshell.api IFC model mutation functions LGPL-3.0-or-later PyPI
ifcfm Extract IFC data for FM handover requirements LGPL-3.0-or-later PyPI
ifcmax Historic extension for IFC support in 3DS Max LGPL-3.0-or-later* Official
ifcmcp MCP server for querying and editing IFC building models LGPL-3.0-or-later PyPI
ifcopenshell-python Python library for IFC manipulation LGPL-3.0-or-later* Official GitHub PyPI Anaconda Anaconda Docker AUR AUR Unstable Pyodide WASM Wheels tag
ifcpatch Utility to run pre-packaged scripts to manipulate IFCs LGPL-3.0-or-later PyPI
ifcquery CLI tool for querying and inspecting IFC building models LGPL-3.0-or-later PyPI
ifcsverchok Blender Add-on for visual node programming with IFC GPL-3.0-or-later GitHub
ifctester Library, CLI and webapp for IDS model auditing LGPL-3.0-or-later PyPI

The IfcOpenShell C++ codebase is split into multiple interal libraries:

Name Description License
ifcgeom Internal library for IfcOpenShell LGPL-3.0-or-later*
ifcgeom_schema_agnostic Internal library for IfcOpenShell LGPL-3.0-or-later*
ifcgeomserver Internal library for IfcOpenShell LGPL-3.0-or-later*
ifcjni Internal library for IfcOpenShell LGPL-3.0-or-later*
ifcparse Internal library for IfcOpenShell LGPL-3.0-or-later*
ifcwrap Internal library for IfcOpenShell LGPL-3.0-or-later*
qtviewer Internal library for IfcOpenShell LGPL-3.0-or-later*
serializers Internal library for IfcOpenShell LGPL-3.0-or-later*
S
Description
No description provided
Readme 487 MiB
Languages
C++ 57.4%
Python 36.2%
C 3.9%
Gherkin 0.7%
JavaScript 0.3%
Other 1.3%