mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-09 17:31:45 +00:00
Doing a transpose was most likely misguided
This commit is contained in:
@@ -55,7 +55,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCartesianTransformationOpera
|
||||
axis3,
|
||||
origin;
|
||||
|
||||
m->components().transposeInPlace();
|
||||
// @todo why was this here
|
||||
// m->components().transposeInPlace();
|
||||
|
||||
return m;
|
||||
}
|
||||
|
||||
@@ -253,8 +253,7 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in
|
||||
// @todo should this not be initialized by default? matrix4 already has a 'lazy identity' mechanism.
|
||||
loft->children.back()->matrix = taxonomy::make<taxonomy::matrix4>();
|
||||
}
|
||||
// @todo why do we do a transpose here, that doesn't seem right.
|
||||
auto m = (m4b * loft->children.back()->matrix->ccomponents().transpose()).eval();
|
||||
auto m = (m4b * loft->children.back()->matrix->ccomponents()).eval();
|
||||
loft->children.back()->matrix->components() = m;
|
||||
}
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user