Glassvision/IfcOpenShell
1
0
Fork 0
mirror of https://github.com/IfcOpenShell/IfcOpenShell.git synced 2026-09-20 15:08:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

Doing a transpose was most likely misguided

Browse Source
This commit is contained in:
Thomas Krijnen
2024-04-12 10:23:27 +02:00
parent 420eed1828
commit 7b296629d6
2 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/ifcgeom/mapping/IfcCartesianTransformationOperator2D.cpp
+2 -1
View File
@@ -55,7 +55,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcCartesianTransformationOpera
axis3, axis3,
origin; origin;
m->components().transposeInPlace(); // @todo why was this here
// m->components().transposeInPlace();
return m; return m;
} }
src/ifcgeom/mapping/IfcSectionedSolidHorizontal.cpp
+1 -2
View File
@@ -253,8 +253,7 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcSectionedSolidHorizontal* in
// @todo should this not be initialized by default? matrix4 already has a 'lazy identity' mechanism. // @todo should this not be initialized by default? matrix4 already has a 'lazy identity' mechanism.
loft->children.back()->matrix = taxonomy::make<taxonomy::matrix4>(); loft->children.back()->matrix = taxonomy::make<taxonomy::matrix4>();
} }
// @todo why do we do a transpose here, that doesn't seem right. auto m = (m4b * loft->children.back()->matrix->ccomponents()).eval();
auto m = (m4b * loft->children.back()->matrix->ccomponents().transpose()).eval();
loft->children.back()->matrix->components() = m; loft->children.back()->matrix->components() = m;
} }
} }