mirror of
https://github.com/IfcOpenShell/IfcOpenShell.git
synced 2026-08-09 17:31:45 +00:00
Removed assert, added Logger::Warning and Logger::Error. Made treatment of unexpected data more permissive
This commit is contained in:
@@ -34,10 +34,6 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcLinearPlacement* inst) {
|
||||
IfcSchema::IfcLinearPlacement* current = (IfcSchema::IfcLinearPlacement*)inst;
|
||||
auto m4 = taxonomy::make<taxonomy::matrix4>();
|
||||
|
||||
#if defined SCHEMA_HAS_IfcAxis2PlacementLinear
|
||||
// IfcLinearPlacement was added in IFC 4.1 but it had an Orientation attribute of type IfcOrientationExpression, which when combined with other
|
||||
// attributes was similar to IfcAxis2PlacementLinear. IFC 4.1 and IFC 4.2 have been withdrawn so I'm not going to try to implement linear placement for them.
|
||||
// For this reason the preprocessor skips this code if SCHEMA_HAS_IfcAxix2PlacementLinear is not defined
|
||||
|
||||
for (;;) {
|
||||
IfcSchema::IfcAxis2PlacementLinear* relplacement = current->RelativePlacement();
|
||||
@@ -84,8 +80,8 @@ taxonomy::ptr mapping::map_impl(const IfcSchema::IfcLinearPlacement* inst) {
|
||||
}
|
||||
}
|
||||
|
||||
// @todo: rb - not sure what this means... it came from IfcLocalPlacement
|
||||
// m4->components() = offset_and_rotation_ * m4->components();
|
||||
// @todo: rb - not sure what this means... it came from IfcLocalPlacement
|
||||
// m4->components() = offset_and_rotation_ * m4->components();
|
||||
|
||||
return m4;
|
||||
|
||||
|
||||
Reference in New Issue
Block a user